weibin0516 commented on a change in pull request #902: KYLIN-3832 Query
pushdown support postgresql
URL: https://github.com/apache/kylin/pull/902#discussion_r341444875
##########
File path: core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java
##########
@@ -90,7 +86,7 @@ public static String
generateCreateTableStatement(IJoinedFlatTableDesc flatDesc,
if (i > 0) {
ddl.append(",");
}
- ddl.append(quoteIdentifier(colName(col, flatDesc.useAlias())) + "
" + getHiveDataType(col.getDatatype()) + "\n");
+ ddl.append(quoteIdentifier(colName(col, flatDesc.useAlias()),
null) + " " + getHiveDataType(col.getDatatype()) + "\n");
Review comment:
`quoteIdentifier(identifier, null)` function is called frequently, how about
add function as below:
```
String quoteIdentifier(String identifier) {
return quoteIdentifier(identifier, null);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
