codecov-io commented on issue #1179: KYLIN-4245 SqlConverter returns wrong syntax SQL when SqlParser fails… URL: https://github.com/apache/kylin/pull/1179#issuecomment-613368349 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1179?src=pr&el=h1) Report > Merging [#1179](https://codecov.io/gh/apache/kylin/pull/1179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/fa4f72d2b12a4e6da60674dfd706ac7ca5534657&el=desc) will **decrease** coverage by `0.00%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/kylin/pull/1179?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1179 +/- ## ============================================ - Coverage 25.00% 25.00% -0.01% - Complexity 6251 6255 +4 ============================================ Files 1449 1449 Lines 88499 88536 +37 Branches 12373 12381 +8 ============================================ + Hits 22129 22135 +6 - Misses 64190 64223 +33 + Partials 2180 2178 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1179?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...in/sdk/datasource/framework/conv/SqlConverter.java](https://codecov.io/gh/apache/kylin/pull/1179/diff?src=pr&el=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2ZyYW1ld29yay9jb252L1NxbENvbnZlcnRlci5qYXZh) | `91.17% <100.00%> (+0.85%)` | `7.00 <3.00> (ø)` | | | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1179/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50.00% <0.00%> (-2.28%)` | `7.00% <0.00%> (-1.00%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1179/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.30% <0.00%> (-0.31%)` | `7.00% <0.00%> (ø%)` | | | [...ava/org/apache/kylin/rest/service/CubeService.java](https://codecov.io/gh/apache/kylin/pull/1179/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9DdWJlU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...ache/kylin/metrics/lib/impl/hive/HiveProducer.java](https://codecov.io/gh/apache/kylin/pull/1179/diff?src=pr&el=tree#diff-bWV0cmljcy1yZXBvcnRlci1oaXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL2hpdmUvSGl2ZVByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/1179/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `82.53% <0.00%> (+0.79%)` | `18.00% <0.00%> (+1.00%)` | | | [...g/apache/kylin/common/util/CliCommandExecutor.java](https://codecov.io/gh/apache/kylin/pull/1179/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0NsaUNvbW1hbmRFeGVjdXRvci5qYXZh) | `31.70% <0.00%> (+2.95%)` | `9.00% <0.00%> (+3.00%)` | | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1179/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `78.37% <0.00%> (+5.40%)` | `7.00% <0.00%> (+1.00%)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1179?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1179?src=pr&el=footer). Last update [fa4f72d...422fd3c](https://codecov.io/gh/apache/kylin/pull/1179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
