[
https://issues.apache.org/jira/browse/KYLIN-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109251#comment-17109251
]
ASF GitHub Bot commented on KYLIN-4491:
---------------------------------------
hit-lacus commented on a change in pull request #1209:
URL: https://github.com/apache/kylin/pull/1209#discussion_r426201246
##########
File path:
query/src/main/java/org/apache/kylin/query/pushdown/PushDownRunnerOtherImpl.java
##########
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kylin.query.pushdown;
+
+import org.apache.kylin.common.KylinConfig;
+import org.apache.kylin.common.util.DBUtils;
+import org.apache.kylin.metadata.querymeta.SelectedColumnMeta;
+import org.apache.kylin.sdk.datasource.framework.JdbcConnector;
+import org.apache.kylin.sdk.datasource.framework.SourceConnectorFactory;
+import org.apache.kylin.source.adhocquery.AbstractPushdownRunner;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.Connection;
+import java.sql.ResultSet;
+import java.sql.ResultSetMetaData;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.LinkedList;
+import java.util.List;
+
+public class PushDownRunnerOtherImpl extends AbstractPushdownRunner {
Review comment:
The name of `PushDownRunnerOtherImpl` is not well defined. Since it is
the the advanced version of elder `PushDownRunnerJdbcImpl`, and reuse some
logic in Data Source SDK. Maybe we change is name to something like
`PushDownRunnerJdbcAdvencedImpl`? What do you think @shaofengshi ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Query push down to Presto
> -------------------------
>
> Key: KYLIN-4491
> URL: https://issues.apache.org/jira/browse/KYLIN-4491
> Project: Kylin
> Issue Type: New Feature
> Components: Integration, RDBMS Source
> Reporter: Shao Feng Shi
> Assignee: fanfanAlice
> Priority: Major
> Fix For: v3.1.0
>
>
> With the data source SDK, we can push down a query to Presto instead of Hive
> or Spark to gain better performance; With the SDK, we can also convert
> Kylin's SQL query to Presto SQL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
