[
https://issues.apache.org/jira/browse/KYLIN-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130000#comment-17130000
]
ASF GitHub Bot commented on KYLIN-4548:
---------------------------------------
codecov-commenter commented on pull request #1251:
URL: https://github.com/apache/kylin/pull/1251#issuecomment-641694287
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1251?src=pr&el=h1) Report
> Merging
[#1251](https://codecov.io/gh/apache/kylin/pull/1251?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/734a997a05bee7b722010b177ec0cce8494bcd1d&el=desc)
will **increase** coverage by `0.64%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/kylin/pull/1251?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1251 +/- ##
============================================
+ Coverage 25.06% 25.71% +0.64%
- Complexity 6250 6625 +375
============================================
Files 1446 1484 +38
Lines 88309 91186 +2877
Branches 12358 12726 +368
============================================
+ Hits 22136 23449 +1313
- Misses 64003 65434 +1431
- Partials 2170 2303 +133
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/1251?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
|---|---|---|---|
|
[.../apache/kylin/rest/controller/QueryController.java](https://codecov.io/gh/apache/kylin/pull/1251/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9RdWVyeUNvbnRyb2xsZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...k/datasource/framework/SourceConnectorFactory.java](https://codecov.io/gh/apache/kylin/pull/1251/diff?src=pr&el=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2ZyYW1ld29yay9Tb3VyY2VDb25uZWN0b3JGYWN0b3J5LmphdmE=)
| `33.33% <0.00%> (-21.67%)` | `1.00% <0.00%> (ø%)` | |
|
[...stream/core/query/MultiThreadsResultCollector.java](https://codecov.io/gh/apache/kylin/pull/1251/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3F1ZXJ5L011bHRpVGhyZWFkc1Jlc3VsdENvbGxlY3Rvci5qYXZh)
| `66.66% <0.00%> (-9.81%)` | `4.00% <0.00%> (+1.00%)` | :arrow_down: |
|
[...e/kylin/storage/gtrecord/CubeScanRangePlanner.java](https://codecov.io/gh/apache/kylin/pull/1251/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0N1YmVTY2FuUmFuZ2VQbGFubmVyLmphdmE=)
| `43.86% <0.00%> (-7.24%)` | `26.00% <0.00%> (ø%)` | |
|
[.../cachemanager/RemoteLocalFailOverCacheManager.java](https://codecov.io/gh/apache/kylin/pull/1251/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9SZW1vdGVMb2NhbEZhaWxPdmVyQ2FjaGVNYW5hZ2VyLmphdmE=)
| `78.57% <0.00%> (-6.05%)` | `7.00% <0.00%> (ø%)` | |
|
[...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1251/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
| `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | |
|
[...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1251/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==)
| `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | |
|
[...va/org/apache/kylin/cube/common/SegmentPruner.java](https://codecov.io/gh/apache/kylin/pull/1251/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NvbW1vbi9TZWdtZW50UHJ1bmVyLmphdmE=)
| `58.46% <0.00%> (-4.04%)` | `26.00% <0.00%> (+1.00%)` | :arrow_down: |
|
[...n/stream/core/query/StreamingCubeDataSearcher.java](https://codecov.io/gh/apache/kylin/pull/1251/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3F1ZXJ5L1N0cmVhbWluZ0N1YmVEYXRhU2VhcmNoZXIuamF2YQ==)
| `41.33% <0.00%> (-3.74%)` | `6.00% <0.00%> (ø%)` | |
|
[...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1251/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=)
| `63.63% <0.00%> (-3.04%)` | `21.00% <0.00%> (-1.00%)` | |
| ... and [217
more](https://codecov.io/gh/apache/kylin/pull/1251/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/1251?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/1251?src=pr&el=footer). Last
update
[734a997...ea0e120](https://codecov.io/gh/apache/kylin/pull/1251?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> When the SQL that needs to export the query results has Chinese, garbled
> characters will be generated
> -----------------------------------------------------------------------------------------------------
>
> Key: KYLIN-4548
> URL: https://issues.apache.org/jira/browse/KYLIN-4548
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: v3.0.2, v2.6.6
> Reporter: ChangjiGuo
> Assignee: ChangjiGuo
> Priority: Major
> Attachments: image-2020-06-09-15-36-21-934.png
>
>
> If we want to export the query results on the WEB UI, and sql contains
> Chinese, this will cause the exported results to be empty, because the query
> executed is not what we want. The following will be specifically explained:
> For example, the sql we want to execute is:
> {code:sql}
> select count(1) from kylin_test.kylin_sales where
> KYLIN_SALES.LSTG_FORMAT_NAME = '中文'
> {code}
> when you execute export, the sql received by kylin server contains garbled
> characters:
> !image-2020-06-09-15-36-21-934.png!
> Therefore, the controller needs to convert the encoding format.
> {code:java}
> sqlRequest.setSql(new
> String(sqlRequest.getSql().getBytes("iso8859-1"),"UTF-8"));
> {code}
> After testing, It works well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
