[
https://issues.apache.org/jira/browse/KYLIN-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142547#comment-17142547
]
ASF GitHub Bot commented on KYLIN-4556:
---------------------------------------
zhangayqian commented on a change in pull request #1254:
URL: https://github.com/apache/kylin/pull/1254#discussion_r443924599
##########
File path:
engine-mr/src/main/java/org/apache/kylin/engine/mr/common/JobInfoConverter.java
##########
@@ -61,6 +61,20 @@ public static JobInstance
parseToJobInstanceQuietly(CheckpointExecutable job, Ma
}
}
+ public static JobInstance parseToJobInstanceQuietly(AbstractExecutable
job, Map<String, Output> outputs) {
+ try {
+ if (job instanceof CheckpointExecutable) {
+ return parseToJobInstance((CheckpointExecutable)job, outputs);
+ } else if (job instanceof CubingJob) {
+ return parseToJobInstance((CubingJob)job, outputs);
+ } else {
+ return null;
+ }
+ } catch (Exception e) {
+ logger.error("Failed to parse job instance: uuid={}", job, e);
+ return null;
+ }
+ }
Review comment:
Hi, @guangxuCheng . Actually this method has replaced
`parseToJobInstanceQuietly(CubingJob job, Map<String, Output> outputs)` and
`parseToJobInstanceQuietly(CheckpointExecutable job, Map<String, Output>
outputs)`, so should the replaced method and their UT be removed? And maybe UT
for this new method should be added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> improve job service
> -------------------
>
> Key: KYLIN-4556
> URL: https://issues.apache.org/jira/browse/KYLIN-4556
> Project: Kylin
> Issue Type: Task
> Reporter: Guangxu Cheng
> Assignee: Guangxu Cheng
> Priority: Major
>
> At present, only cubing and checkpoint jobs can be obtained through job
> API,for cardinality and lookup snapshot job, we can't get them which is very
> inconvenient.
> when the cardinality task fails, we can only find the reason why the task
> failed from the system log, and we cannot rerun or delete these failed tasks
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
