[
https://issues.apache.org/jira/browse/KYLIN-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17188501#comment-17188501
]
ASF GitHub Bot commented on KYLIN-4725:
---------------------------------------
hit-lacus commented on a change in pull request #1387:
URL: https://github.com/apache/kylin/pull/1387#discussion_r481175258
##########
File path:
core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
##########
@@ -196,8 +196,10 @@ public final ExecuteResult execute(ExecutableContext
executableContext) throws E
try {
result = doWork(executableContext);
} catch (Throwable e) {
- logger.error("error running Executable: {}",
this.toString());
- catchedException = e;
+ if (!(e instanceof JobStoppedException)) {
Review comment:
Could you please change to this way:
```java
} catch (JobStoppedException e) {
// Ignore it
} catch (Throwable e) {
throw new ExecuteException(e);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> NSparkCubingStep returns error state when pause build job
> ---------------------------------------------------------
>
> Key: KYLIN-4725
> URL: https://issues.apache.org/jira/browse/KYLIN-4725
> Project: Kylin
> Issue Type: Bug
> Components: Job Engine
> Affects Versions: v4.0.0-alpha
> Reporter: Zhichao Zhang
> Assignee: Yaqian Zhang
> Priority: Major
>
> When pause a build job, NSparkCubingStep returns ExecuteResult.State.ERROR
> state, it must be ExecuteResult.State.STOPPED.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
