[
https://issues.apache.org/jira/browse/KYLIN-4936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310221#comment-17310221
]
ASF GitHub Bot commented on KYLIN-4936:
---------------------------------------
zhengshengjun commented on a change in pull request #1619:
URL: https://github.com/apache/kylin/pull/1619#discussion_r602889056
##########
File path:
kylin-spark-project/kylin-spark-query/src/main/scala/org/apache/kylin/query/runtime/plans/AggregatePlan.scala
##########
@@ -115,7 +137,7 @@ object AggregatePlan extends LogEx {
val aggName = SchemaProcessor.replaceToAggravateSchemaName(index,
funcName, hash, argNames: _*)
if (funcName == FunctionDesc.FUNC_COUNT_DISTINCT) {
Review comment:
should we replace "funcName == FunctionDesc.FUNC_COUNT_DISTINCT" with
call.getFunc.isCountDistinct ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Exactly aggregation can't transform to project
> ----------------------------------------------
>
> Key: KYLIN-4936
> URL: https://issues.apache.org/jira/browse/KYLIN-4936
> Project: Kylin
> Issue Type: Improvement
> Components: Query Engine
> Affects Versions: v4.0.0-beta
> Reporter: ShengJun Zheng
> Assignee: Zhichao Zhang
> Priority: Major
> Fix For: v4.0.0-GA
>
>
> Exactly Aggregate can't transform to project, causing unnecessary spark
> shuffle !
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
