[
https://issues.apache.org/jira/browse/KYLIN-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320226#comment-17320226
]
ASF GitHub Bot commented on KYLIN-4780:
---------------------------------------
coveralls edited a comment on pull request #1596:
URL: https://github.com/apache/kylin/pull/1596#issuecomment-791204373
## Pull Request Test Coverage Report for [Build
7065](https://coveralls.io/builds/38770165)
* **57** of **333** **(17.12%)** changed or added relevant lines in
**20** files are covered.
* **35** unchanged lines in **10** files lost coverage.
* Overall coverage decreased (**-0.02%**) to **28.073%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[core-common/src/main/java/org/apache/kylin/common/notify/util/NotificationConstants.java](https://coveralls.io/builds/38770165/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fnotify%2Futil%2FNotificationConstants.java#L21)
| 0 | 1 | 0.0%
|
[engine-mr/src/main/java/org/apache/kylin/engine/mr/LookupSnapshotBuildJob.java](https://coveralls.io/builds/38770165/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2FLookupSnapshotBuildJob.java#L69)
| 0 | 2 | 0.0%
|
[server-base/src/main/java/org/apache/kylin/rest/constant/NotifyType.java](https://coveralls.io/builds/38770165/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fconstant%2FNotifyType.java#L21)
| 0 | 2 | 0.0%
|
[core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java](https://coveralls.io/builds/38770165/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java#L537)
| 10 | 13 | 76.92%
|
[core-common/src/main/java/org/apache/kylin/common/notify/util/SecretKeyUtil.java](https://coveralls.io/builds/38770165/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fnotify%2Futil%2FSecretKeyUtil.java#L30)
| 8 | 12 | 66.67%
|
[core-common/src/main/java/org/apache/kylin/common/notify/NotifyServiceBase.java](https://coveralls.io/builds/38770165/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fnotify%2FNotifyServiceBase.java#L31)
| 0 | 5 | 0.0%
|
[core-common/src/main/java/org/apache/kylin/common/notify/util/DingTalkNotificationUtil.java](https://coveralls.io/builds/38770165/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fnotify%2Futil%2FDingTalkNotificationUtil.java#L26)
| 12 | 17 | 70.59%
|
[server-base/src/main/java/org/apache/kylin/rest/job/KylinHealthCheckJob.java](https://coveralls.io/builds/38770165/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FKylinHealthCheckJob.java#L140)
| 0 | 5 | 0.0%
|
[cube-migration/src/main/java/org/apache/kylin/rest/service/MigrationRuleSet.java](https://coveralls.io/builds/38770165/source?filename=cube-migration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FMigrationRuleSet.java#L84)
| 0 | 6 | 0.0%
|
[server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java](https://coveralls.io/builds/38770165/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FCubeService.java#L582)
| 0 | 6 | 0.0%
<!-- | **Total:** | **57** | **333** | **17.12%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[cube-migration/src/main/java/org/apache/kylin/rest/service/MigrationService.java](https://coveralls.io/builds/38770165/source?filename=cube-migration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FMigrationService.java#L236)
| 1 | 0% |
|
[engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java](https://coveralls.io/builds/38770165/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2FCubingJob.java#L167)
| 1 | 1.48% |
|
[engine-mr/src/main/java/org/apache/kylin/engine/mr/LookupSnapshotBuildJob.java](https://coveralls.io/builds/38770165/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2FLookupSnapshotBuildJob.java#L71)
| 1 | 0% |
|
[server-base/src/main/java/org/apache/kylin/rest/job/KylinHealthCheckJob.java](https://coveralls.io/builds/38770165/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FKylinHealthCheckJob.java#L143)
| 1 | 0% |
|
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/GeneralColumnDataReader.java](https://coveralls.io/builds/38770165/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FGeneralColumnDataReader.java#L43)
| 1 | 92.11% |
|
[cube-migration/src/main/java/org/apache/kylin/rest/service/MigrationRuleSet.java](https://coveralls.io/builds/38770165/source?filename=cube-migration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FMigrationRuleSet.java#L216)
| 2 | 0% |
|
[tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/38770165/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L51)
| 2 | 76.32% |
|
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/38770165/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
| 5 | 77.81% |
|
[core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java](https://coveralls.io/builds/38770165/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fexecution%2FAbstractExecutable.java#L240)
| 5 | 61.18% |
|
[engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkCubingByLayer.java](https://coveralls.io/builds/38770165/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkCubingByLayer.java#L531)
| 16 | 0% |
<!-- | **Total:** | **35** | | -->
| Totals | [](https://coveralls.io/builds/38770165)
|
| :-- | --: |
| Change from base [Build 7032](https://coveralls.io/builds/38574273): |
-0.02% |
| Covered Lines: | 26752 |
| Relevant Lines: | 95296 |
---
##### đź’› - [Coveralls](https://coveralls.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor AbstractExecutable to extract the notification relevant business
> logic into a single component
> -------------------------------------------------------------------------------------------------------
>
> Key: KYLIN-4780
> URL: https://issues.apache.org/jira/browse/KYLIN-4780
> Project: Kylin
> Issue Type: Improvement
> Components: Integration
> Reporter: vinoyang
> Assignee: chenjie
> Priority: Major
>
> Currently, Kylin supports mail service to know the change around the cube.
> However, there are some issues about the design, e.g.
> * AbstractExecutable contains an implementation of the mechanism of a
> notification listener, but only support mail service, it does not belong
> there;
> * The current implementation is hard to scale to other notification e.g.
> Ding Talk(which is a popular production supports by Alibaba)
> I propose to refactor the current implementation to extract the notification
> logic and redesign a new common notification/listener
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
