shaofengshi commented on pull request #1596: URL: https://github.com/apache/kylin/pull/1596#issuecomment-828909043
Hello chenjie @chenjie-sau , Thanks for raising this PR! I think this is a good feature, but for the implementation, it can be improved a little bit. Firstly, the dingding sdk's license is unknown, so it is not okya for Kylin to bundle it in the release. Secondly, the notification module can be designed as pluggable. For example, user can implement an interface and then config the implementation class in kylin.properties. Kylin then will load the class at runtime by name, and then send the notification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
