[
https://issues.apache.org/jira/browse/KYLIN-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335111#comment-17335111
]
ASF GitHub Bot commented on KYLIN-4780:
---------------------------------------
shaofengshi commented on pull request #1596:
URL: https://github.com/apache/kylin/pull/1596#issuecomment-828909043
Hello chenjie @chenjie-sau ,
Thanks for raising this PR!
I think this is a good feature, but for the implementation, it can be
improved a little bit. Firstly, the dingding sdk's license is unknown, so it is
not okya for Kylin to bundle it in the release. Secondly, the notification
module can be designed as pluggable. For example, user can implement an
interface and then config the implementation class in kylin.properties. Kylin
then will load the class at runtime by name, and then send the notification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor AbstractExecutable to extract the notification relevant business
> logic into a single component
> -------------------------------------------------------------------------------------------------------
>
> Key: KYLIN-4780
> URL: https://issues.apache.org/jira/browse/KYLIN-4780
> Project: Kylin
> Issue Type: Improvement
> Components: Integration
> Reporter: vinoyang
> Assignee: chenjie
> Priority: Major
>
> Currently, Kylin supports mail service to know the change around the cube.
> However, there are some issues about the design, e.g.
> * AbstractExecutable contains an implementation of the mechanism of a
> notification listener, but only support mail service, it does not belong
> there;
> * The current implementation is hard to scale to other notification e.g.
> Ding Talk(which is a popular production supports by Alibaba)
> I propose to refactor the current implementation to extract the notification
> logic and redesign a new common notification/listener
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
