[
https://issues.apache.org/jira/browse/KYLIN-5019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396689#comment-17396689
]
ASF GitHub Bot commented on KYLIN-5019:
---------------------------------------
codecov-commenter commented on pull request #1720:
URL: https://github.com/apache/kylin/pull/1720#issuecomment-896041638
#
[Codecov](https://codecov.io/gh/apache/kylin/pull/1720?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> :exclamation: No coverage uploaded for pull request base (`main@dc499be`).
[Click here to learn what that
means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1720?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1720 +/- ##
=======================================
Coverage ? 24.64%
Complexity ? 4451
=======================================
Files ? 1092
Lines ? 61885
Branches ? 8891
=======================================
Hits ? 15251
Misses ? 45028
Partials ? 1606
```
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/1720?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/1720?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[dc499be...ea94184](https://codecov.io/gh/apache/kylin/pull/1720?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Avoid building global dictionary from all data of fact table each time
> ----------------------------------------------------------------------
>
> Key: KYLIN-5019
> URL: https://issues.apache.org/jira/browse/KYLIN-5019
> Project: Kylin
> Issue Type: New Feature
> Affects Versions: v4.0.0-beta
> Reporter: Shengjun Zheng
> Priority: Major
>
> Global dictionaries will be resized to avoid single dictionary bucket
> exceeding its threashold in each cubing job. To judge whether a dictionary
> should be resized, Kylin will read all data from fact table and do count
> distinct operation. Then rebuild dictionary from all history data.
> It’s better to use a lightweight approach, since dictionary don't need to be
> resized for incremental building in most cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
