zznlime commented on code in PR #1969: URL: https://github.com/apache/kylin/pull/1969#discussion_r971926576
########## src/core-common/src/main/java/org/apache/kylin/common/util/Unsafe.java: ########## @@ -29,6 +29,7 @@ import org.apache.commons.lang.StringUtils; import lombok.extern.slf4j.Slf4j; +import org.apache.kylin.common.KylinConfigBase; Review Comment: Have removed KylinConfigBase import from Unsafe.java ########## src/core-common/src/main/java/org/apache/kylin/common/util/Unsafe.java: ########## @@ -113,7 +114,7 @@ public static void restoreAllSystemProp(Map<String, String> systemProp) { /** Set system property */ public static String setProperty(String property, String value) { - return System.setProperty(property, value); + return KylinConfigBase.setSystemProperty(property, value); Review Comment: Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org