[
https://issues.apache.org/jira/browse/KYLIN-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620839#comment-17620839
]
ASF GitHub Bot commented on KYLIN-5279:
---------------------------------------
zznlime opened a new pull request, #2001:
URL: https://github.com/apache/kylin/pull/2001
according to pgsql:
https://www.postgresql.org/docs/current/queries-order.html
By default, null values sort as if larger than any non-null value; that is,
NULLS FIRST is the default for DESC order, and NULLS LAST otherwise.
## Branch to commit
- [ ] Branch **kylin3** for v2.x to v3.x
- [ ] Branch **kylin4** for v4.x
- [ x ] Branch **kylin5** for v5.x
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ x ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look for
before merging your code._
- [x] I have created an issue on [Kylin's
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the
bug/feature there in detail
- [x] Commit messages in my PR start with the related jira ID, like
"KYLIN-5279 Make Kylin project open-source"
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature
works
- [ ] I have added necessary documentation (if appropriate)
- [ ] Any dependent changes have been merged
> Default null collation for Kylin5.0 sqls should be null-last for ASC order
> and null-first for DESC order.
> ---------------------------------------------------------------------------------------------------------
>
> Key: KYLIN-5279
> URL: https://issues.apache.org/jira/browse/KYLIN-5279
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
> Reporter: Zhenning Zhang
> Assignee: Zhenning Zhang
> Priority: Major
> Fix For: 5.0-alpha
>
> Attachments: image-2022-10-20-15-12-12-967.png
>
>
> according to pgsql:
> [https://www.postgresql.org/docs/current/queries-order.html]
> "By default, null values sort as if larger than any non-null value; that is,
> {{NULLS FIRST}} is the default for {{DESC}} order, and {{NULLS LAST}}
> otherwise."
> currently, the result is:
> !image-2022-10-20-15-12-12-967.png|width=1320,height=743!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
