hit-lacus commented on PR #2001: URL: https://github.com/apache/kylin/pull/2001#issuecomment-1290073592
Here is my suggestion.You don't need add a new config entry like: `kylin.query.asc-order-null-first-enable`. Looks like you can reuse existent config entry in `KylinConfigBase#getCalciteExtrasProperties` and remove the overwrite method `defaultNullCollation` of KECalciteConfig. After that, you just need set "kylin.query.calcite.extras-props.defaultNullCollation=low/high/first/last" in kylin.properties . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org