[ 
https://issues.apache.org/jira/browse/KYLIN-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623636#comment-17623636
 ] 

ASF GitHub Bot commented on KYLIN-5280:
---------------------------------------

hit-lacus commented on PR #2002:
URL: https://github.com/apache/kylin/pull/2002#issuecomment-1290145746

   After check, I have following commnets:
   
   1. Looks like a lot of configuration entries is hard-coded in 
`MemcachedCacheConfig`, such as `timeout`, do they really not need be 
configured by kylin users?
   2. Would you please add unit test for `CompositeMemcachedCache`? A good 
example is `QueryRedisCacheTest`. And I find a embedded-memcached in 
https://github.com/mwarc/embedded-memcached-spring.
   
   @zznlime 




> Introduce memcached as a distributed query cache for Kylin5
> -----------------------------------------------------------
>
>                 Key: KYLIN-5280
>                 URL: https://issues.apache.org/jira/browse/KYLIN-5280
>             Project: Kylin
>          Issue Type: New Feature
>    Affects Versions: 5.0-alpha
>            Reporter: Zhenning Zhang
>            Assignee: Zhenning Zhang
>            Priority: Major
>             Fix For: 5.0-alpha
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to