dethrive commented on code in PR #2089: URL: https://github.com/apache/kylin/pull/2089#discussion_r1107478639
########## src/spark-project/engine-spark/src/main/scala/org/apache/kylin/engine/spark/model/planner/CuboIdToLayoutUtils.java: ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kylin.engine.spark.model.planner; + +import java.math.BigInteger; +import java.util.ArrayList; +import java.util.Collections; +import java.util.Comparator; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; + +import org.apache.kylin.metadata.cube.cuboid.NAggregationGroup; +import org.apache.kylin.metadata.cube.model.LayoutEntity; +import org.apache.kylin.metadata.cube.model.RuleBasedIndex; + +import com.google.common.collect.Lists; + +public class CuboIdToLayoutUtils { + /** + * convert the cuboids to layout entity + * + * @param cuboids + * @param ruleBasedIndex + * @return + */ + public static Set<LayoutEntity> convertCuboIdsToLayoutEntity(Map<BigInteger, Long> cuboids, + RuleBasedIndex ruleBasedIndex) { + // convert the cuboid to each agg group + Set<LayoutEntity> result = new HashSet<>(); + List<NAggregationGroup> aggregationGroups = ruleBasedIndex.getAggregationGroups(); + for (NAggregationGroup group : aggregationGroups) { + // dimension order in this agg group + List<Integer> dimensionOrder = Lists.newArrayList(group.getIncludes()); + // measure order in this agg group + List<Integer> measuresIds = Lists.newArrayList(group.getMeasures()); + Set<List<Integer>> colOrders = convertCuboIdsToColOrders(cuboids, ruleBasedIndex.countOfIncludeDimension(), + measuresIds, ruleBasedIndex.getRowKeyIdToColumnId(), dimensionOrder); + for (List<Integer> colOrder : colOrders) { + result.add(createRecommendAggIndexLayout(colOrder)); + } + } + + // base agg layout for each agg group + for (NAggregationGroup group : aggregationGroups) { + List<Integer> colOrders = Lists.newArrayList(); + // all dimension in the agg + colOrders.addAll(Lists.newArrayList(group.getIncludes())); + // all measure in this agg + colOrders.addAll(Lists.newArrayList(group.getMeasures())); + result.add(createRecommendAggIndexLayout(colOrders)); + } + return result; + } + + /** + * create recommend agg layout base on the colOrder. + * + * @param colOrder + * @return LayoutEntity or null + * null: if the measures in the colOrder can't match the measures in this Index Plan + */ + private static LayoutEntity createRecommendAggIndexLayout(List<Integer> colOrder) { + LayoutEntity newAddIndexLayout = new LayoutEntity(); + // The layout is not the manual + newAddIndexLayout.setManual(false); Review Comment: 另外，这个类里面的所有的 cuboid 相关的叫法建议改成 layout， 从而 convertCuboIdsToLayoutEntity 这种方法名都可以叫 convertLayoutIdToEntity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
