[
https://issues.apache.org/jira/browse/KYLIN-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691062#comment-17691062
]
ASF GitHub Bot commented on KYLIN-5387:
---------------------------------------
liukun4515 commented on code in PR #2089:
URL: https://github.com/apache/kylin/pull/2089#discussion_r1111607847
##########
src/spark-project/engine-spark/src/main/java/org/apache/kylin/engine/spark/merger/AfterBuildResourceMerger.java:
##########
@@ -52,6 +52,7 @@ public AfterBuildResourceMerger(KylinConfig config, String
project) {
@Override
public NDataLayout[] merge(String dataflowId, Set<String> segmentId,
Set<Long> layoutIds,
ResourceStore remoteResourceStore, JobTypeEnum jobType, Set<Long>
partitions) {
+ // TODO checker the input layouts
Review Comment:
> 为什么要加这个 todo。如果这边有问题，建议开个 follow up 的 issue 描述一下这边存在的问题。
commit for cleanup code:
https://github.com/apache/kylin/pull/2089/commits/169c7c1975c5cc47b21a1bd8e25b25293cfa23ee
##########
src/spark-project/engine-spark/src/main/java/org/apache/kylin/engine/spark/merger/AfterMergeOrRefreshResourceMerger.java:
##########
@@ -170,6 +172,7 @@ public NDataLayout[] mergeNormalModel(String dataflowId,
Set<String> segmentIds,
@Override
public NDataLayout[] merge(String dataflowId, Set<String> segmentIds,
Set<Long> layoutIds,
ResourceStore remoteResourceStore, JobTypeEnum jobType, Set<Long>
partitions) {
+ // TODO checker the input layouts
Review Comment:
https://github.com/apache/kylin/pull/2089/commits/169c7c1975c5cc47b21a1bd8e25b25293cfa23ee
> Migrate cube planner phase 1 to kylin5
> --------------------------------------
>
> Key: KYLIN-5387
> URL: https://issues.apache.org/jira/browse/KYLIN-5387
> Project: Kylin
> Issue Type: Improvement
> Components: Job Engine
> Affects Versions: 5.0-alpha
> Reporter: Kun Liu
> Assignee: Kun Liu
> Priority: Major
>
> kylin3.1 support the cube planner to recommend cuboid when building the first
> segment.
>
> We need to migrate the cost based algorithm to the kylin5, and leverage the
> cube planner algorithm with the index in kylin5
>
> designe doc:
> https://docs.google.com/document/d/1wUNd8U1u-w8T-qQUReplPhDFkETj3AtFr_Shex501ls/edit?usp=sharing
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
