[ 
https://issues.apache.org/jira/browse/KYLIN-6030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928310#comment-17928310
 ] 

Guoliang Sun commented on KYLIN-6030:
-------------------------------------

Checked the entire TableController, and found no other issues except that 
`has_Internal` and `rangePartition` in TableDesc do not comply with the naming 
conventions.  
The involved interfaces are `/tables`, `/tables/model_tables`, and 
`/tables/project_tables`.  
`has_Internal` is only directly updated during internal table addition and 
deletion, and `rangePartition` is only fetched during loading without any 
updates.  
Therefore, renaming these attributes will not cause issues when the frontend 
uses them as parameters for update or insert interfaces.
h3. Dev Design

TableDesc will support deserialization of historical fields `has_Internal` and 
`rangePartition`. Add new fields `has_internal` and `range_partition`. When the 
new fields `has_internal` and `range_partition` do not exist, the values of the 
historical fields will be used. Serialization of historical fields will not be 
supported, meaning `has_Internal` and `rangePartition` will not be serialized 
into JSON fields.  
Add compatible fields, methods, and constructors for backward compatibility.

> Inconsistent attribute name style in the tables response message
> ----------------------------------------------------------------
>
>                 Key: KYLIN-6030
>                 URL: https://issues.apache.org/jira/browse/KYLIN-6030
>             Project: Kylin
>          Issue Type: Improvement
>    Affects Versions: 5.0.0
>            Reporter: Guoliang Sun
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to