[
https://issues.apache.org/jira/browse/KYLIN-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070929#comment-18070929
]
ASF GitHub Bot commented on KYLIN-4044:
---------------------------------------
codecov-commenter commented on PR #703:
URL: https://github.com/apache/kylin/pull/703#issuecomment-4185388985
##
[Codecov](https://app.codecov.io/gh/apache/kylin/pull/703?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 25.72%. Comparing base
([`9708990`](https://app.codecov.io/gh/apache/kylin/commit/970899011211b285b78cfc3a63ac5025436ddb59?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`958a3e8`](https://app.codecov.io/gh/apache/kylin/commit/958a3e8fae5b3c3c850a7c2c736527c73ca9ad30?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #703 +/- ##
============================================
- Coverage 25.74% 25.72% -0.02%
+ Complexity 6014 6012 -2
============================================
Files 1385 1385
Lines 82424 82424
Branches 11557 11557
============================================
- Hits 21216 21207 -9
- Misses 59167 59173 +6
- Partials 2041 2044 +3
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/kylin/pull/703?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> CuratorScheduler may throw NPE when init service Cache
> ------------------------------------------------------
>
> Key: KYLIN-4044
> URL: https://issues.apache.org/jira/browse/KYLIN-4044
> Project: Kylin
> Issue Type: Bug
> Affects Versions: v3.0.0
> Reporter: PENG Zhengshuai
> Assignee: PENG Zhengshuai
> Priority: Major
> Fix For: v3.0.0-alpha2
>
>
> Currently Kylin uses Curator 2.12.0 dependencies.
> There is an issue of CURATOR-452 which may affect Kylin Server Discovery.
> When kylin server starts, it will discover other kylin server nodes in ZK
> path, and then register itself to ZK path. Curator discovery and cache
> implementation will initialize the service cache and deserialize the
> ServiceInstance by * JsonInstanceSerializer* which implemented by Kylin.
> But the CURATOR-452 hasn't been back-ported to curator-2.x branch.
> This curator issue may pass a *Null* value in
> *JsonInstanceSerializer#deserialize(byte[] bytes)* and it will cause the NPE.
> Kylin now uses the zookeeper version dependency with version 3.4.13, so
> according to the curator compatibility in
> https://curator.apache.org/zk-compatibility.html#, I think it's safe to
> upgrade the Curator version to 4.0+ in Kylin
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
