[ 
https://issues.apache.org/jira/browse/KYLIN-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743024#comment-14743024
 ] 

liyang commented on KYLIN-1014:
-------------------------------

This is great patch. Two comments though.

- It introduces HttpComponents but didn't remove commons-httpclient. We don't 
need two duplicate http client in dependency. All occurrence of 
commons-httpclient should be replaced.
- It introduces new config "kylin.job.status.with.kerberos". But better, we 
should look into Hadoop config to see if ResourceManager requires kerberos 
authentication. Repeat the config in Kylin is not the best idea.

Feng Yu may not have all the context, but committer who merge the patch must 
consider the above.

> patch for supporting kerberos authentication while getting status from RM
> -------------------------------------------------------------------------
>
>                 Key: KYLIN-1014
>                 URL: https://issues.apache.org/jira/browse/KYLIN-1014
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Job Engine
>    Affects Versions: v1.0, v0.7.2, v0.7.1
>            Reporter: fengYu
>            Assignee: Shaofeng SHI
>         Attachments: 0001-kerberos.patch
>
>
> I have used kylin-0.7.2 build cube and do some query, and I am trying 
> kylin-1.0 in another hadoop cluster. I get this problem below in kylin-0.7.2 
> and kylin-1.0 :
> Our hadoop cluster deals with authentication with kerberos, However, We find 
> after submit a mapreduce job(the second step in building cube), kylin will 
> send a http request to RM server and get the job status at regular intervals, 
> But we always get errors here because kylin do nothing about kerberos. 
> Finally , we do some change on source code and make it support kerberos 
> authentication . attachment is my patch file..
> I add a property named "kylin.job.status.with.kerberos" which means if we 
> need do authentication with kerberos when getting status from RM, the default 
> value is false.
> It will be highly appreciated if you have some good idea or some suggestion. 
> Thanks...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to