[
https://issues.apache.org/jira/browse/KYLIN-999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shaofeng SHI reopened KYLIN-999:
--------------------------------
Justin gave some comments in the v1.1 release RC1, we need check the license of
these two fonts file:
It’s +0 (binding) from me.
I checked:
- release name includes incubating
- signatures and hashes correct
- DISCLAIMER exists
- LICENSE is OK, but probably missing font license
- NOTICE all good
- All source files have apache headers (a few test files and data files don’t)
- A couple of unexpected binary files in release
- Can compile from source
There are two binary font files, whose licensing I’m unsure of in the source
package:
./webapp/app/fonts/ODelI1aHBYDBqgeIAH2zlPytCVloACqnDHJwh-em2k8.woff2
(may be Source San Pro which is covered by a SIL license so that would also
need to go into
the LICENSE file or be removed)
./webapp/app/fonts/toadOcfmlt9b38dHJxOBGKUt5Ot5NIMarvNW-hkYWvT3rGVtsTkPsbDajuO5ueQw.woff2
(may be Source Sans Pro Bold?)
This issue was brought up before [1] in a previous release.
Thanks,
Justin
> License check and cleanup for release
> -------------------------------------
>
> Key: KYLIN-999
> URL: https://issues.apache.org/jira/browse/KYLIN-999
> Project: Kylin
> Issue Type: Improvement
> Components: General
> Affects Versions: v1.0
> Reporter: Luke Han
> Assignee: Luke Han
> Fix For: v1.1
>
>
> Hi,
> Sorry but it’s -1 (binding), although you have enough +1 to go ahead and make
> a release.
> This issue that has occurred before [1] and even if the website isn’t
> included in the release it looks like there may be a still few issues to fix
> there.
> I checked
> - package contains incubating
> - Signatures good
> - DISCLAIMER exits
> - LICENSE issues (see below)
> - NOTICE fine
> - No unexpected binary files
> - All source file have apache headers
> The file ./website/assets/css/animate.css has had an Apache header put on it
> when it is MIT licensed. There are probably other files that are incorrect in
> this way but I’ve not looked in detail. Perhaps
> ./website/assets/fonts/helveticaneue-webfont.svg and
> ./website/assets/fonts/helveticaneue-webfont.css? but that may have a more
> serious issue.
> The font files ./website/assets/fonts/helveticaneue-webfont.* seem to
> licensed like so (from the font meta data):
> "Copyright (c) 1988, 1990 Adobe Systems Incorporated. All Rights
> Reserved.Helvetica is a registered trademark of Linotype AG and/or its
> subsidiaries.”
> Other minor LICENSE issues:
> - Missing MIT licensed for animate.css
> - Missing MIT for Bootstrap and normalise.css
> - Missing MIT for jQuery
> - Missing MIT for font awsome
> - Missing SIL for font awsome
> Not required but you may want to add Apache license for the open sans font to
> LICENSE as it not immediately obvious how that binary file is licensed.
> Thanks,
> Justin
> 1. http://apache.markmail.org/message/z6k3yivyo6xz24by
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
