[
https://issues.apache.org/jira/browse/LIVY-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183731#comment-16183731
]
ASF GitHub Bot commented on LIVY-41:
------------------------------------
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/48#discussion_r141531618
--- Diff: server/src/main/scala/org/apache/livy/server/SessionServlet.scala
---
@@ -214,16 +215,23 @@ abstract class SessionServlet[S <: Session, R <:
RecoveryMetadata](
private def doWithSession(fn: (S => Any),
allowAll: Boolean,
checkFn: Option[(String, HttpServletRequest) => Boolean]): Any = {
- val sessionId = params("id").toInt
- sessionManager.get(sessionId) match {
+ val idParam: String = params("id")
--- End diff --
Let's rename this variable as `idOrNameParam` to be clear.
> Need a way to submit codes through Named Session instead of Session ID numbers
> ------------------------------------------------------------------------------
>
> Key: LIVY-41
> URL: https://issues.apache.org/jira/browse/LIVY-41
> Project: Livy
> Issue Type: New Feature
> Components: Core
> Affects Versions: 0.1
> Reporter: Prabhu Kasinathan
> Priority: Minor
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Currently, we are creating new pyspark session and submitting codes through
> newly created session id as below
> curl -X POST --data '
> {"kind": "pyspark", "queue": "spark", "name": "Livy_Example"}
> ' -H "Content-Type: application/json" localhost:8998/sessions
> curl localhost:8998/sessions/1/statements -X POST -H 'Content-Type:
> application/json' -d '
> {"code":"1 + 1"}
> '
> But, it would be nice if we have a way to submit the codes through session
> name instead of session id. That way, we need not to maintain a lookup table
> for session-id to session-name. Users will be able to submit their codes
> easily as below through session names instead of worrying about session id.
> curl -X POST --data '
> {"kind": "pyspark", "queue": "spark", "name": "mkt_risk_batch"}
> ' -H "Content-Type: application/json" localhost:8998/sessions
> curl localhost:8998/sessions/mkt_risk_batch/statements -X POST -H
> 'Content-Type: application/json' -d '
> {"code":"1 + 1"}
> '
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
