[ 
https://issues.apache.org/jira/browse/LIVY-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208152#comment-16208152
 ] 

ASF GitHub Bot commented on LIVY-409:
-------------------------------------

GitHub user ericjperry reopened a pull request:

    https://github.com/apache/incubator-livy/pull/55

    [LIVY-409] Livy shell UX improvements

    I'm not sure how large of an audience the livy-shell has, but I've come to 
use it quite a bit in my testing/use of Livy and added a few small improvements 
that have made it a bit easier to use for me (and may help others):
    
    * Replaced the use of httplib with requests to fix dropped connection 
issues (and a few other robustness issues).
    * Added some context to the REPL prompt, by including the session `kind` 
and ID.
    * Ignore `SIGINT` signal so that users can type `CTRL-C` to cancel out a 
command.
    
    I know the use of `requests` is pretty ubiquitous but I included 
`livy-shell-requirements.txt` just in case 1) someone doesn't have it installed 
or 2) more dependencies are added down the road.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ericjperry/incubator-livy 
feature/livy-shell-improvements

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-livy/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #55
    
----
commit f45110c2f24d9b0d1e8645de09e7eda94b959487
Author: Eric Perry <e...@ericjperry.com>
Date:   2017-10-05T15:48:37Z

    Minor livy-shell UX improvements

commit da809a902423856b5c828d8c5a65ab4dcc33e95a
Author: Eric Perry <e...@ericjperry.com>
Date:   2017-10-05T15:50:02Z

    Add requirements file for livy-shell

commit 3b282afad13e3550387aba11850fbdc61ee01496
Author: Eric Perry <e...@ericjperry.com>
Date:   2017-10-05T15:54:15Z

    Remove commented code

commit 64a5abf423b9ae70eebaf04f6c78ef3f4c4862c2
Author: Eric Perry <e...@ericjperry.com>
Date:   2017-10-05T18:05:46Z

    Remove livy-shell-requirements.txt, check for requests at launch.

commit 494a0b32a3f61ff216a23a99e313f25cf8c59152
Author: Eric Perry <e...@ericjperry.com>
Date:   2017-10-05T21:06:42Z

    Use raise_for_status in favor of raising HTTPException

commit a8bf1f796d069df4a83d66432ac5a92aee4a6236
Author: Eric Perry <e...@ericjperry.com>
Date:   2017-10-11T22:00:12Z

    Fixed issue with commands being concatenated.

commit e09ff965f602913cfb82bc5ddb3432105511666a
Author: Eric Perry <e...@ericjperry.com>
Date:   2017-10-13T13:32:11Z

    Add parens to print and use message for python 3 compatibility

commit c78150e2859c0094ef9e16304f8b15123dab764e
Author: Eric Perry <e...@ericjperry.com>
Date:   2017-10-13T13:51:07Z

    Added CSRF token to requests

----


> Improve User Experience in livy-shell
> -------------------------------------
>
>                 Key: LIVY-409
>                 URL: https://issues.apache.org/jira/browse/LIVY-409
>             Project: Livy
>          Issue Type: Improvement
>            Reporter: Eric Perry
>            Priority: Minor
>
> The livy-shell is useful in testing and evaluation of the use of Livy, but 
> has a few minor UX issues that could be fixed without many changes:
> # The use of httplib and a single connection can cause problems in 
> environments where network reliability is low.
> # The shell prompt does not include any contextual information, which may be 
> helpful when a user has multiple shells running.
> # There isn't an easy way to cancel the current command other than deleting 
> all the text on the prompt as SIGINT breaks out of the REPL and causes the 
> session to be deleted.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to