[ 
https://issues.apache.org/jira/browse/SOLR-13180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935123#comment-16935123
 ] 

Munendra S N commented on SOLR-13180:
-------------------------------------

 [^SOLR-13180.patch] 
Moved the check to {{ObjectUtil}} with previous patch {{json.limit=5}} would 
fail instead of succeeding but now, error message won't contain query parameter 
name


> ClassCastExceptions in o.a.s.s.facet.FacetModule for valid JSON inputs that 
> are not objects
> -------------------------------------------------------------------------------------------
>
>                 Key: SOLR-13180
>                 URL: https://issues.apache.org/jira/browse/SOLR-13180
>             Project: Solr
>          Issue Type: Bug
>          Components: Facet Module
>    Affects Versions: 7.5, master (9.0)
>         Environment: Running on Unix, using a git checkout close to master.
> h2. Steps to reproduce
>  * Build commit ea2c8ba of Solr as described in the section below.
>  * Build the films collection as described below.
>  * Start the server using the command \{{“./bin/solr start -f -p 8983 -s 
> /tmp/home”}}
>  * Request the URL above.
> h2. Compiling the server
> {noformat}
> git clone https://github.com/apache/lucene-solr
> cd lucene-solr
> git checkout ea2c8ba
> ant compile
> cd solr
> ant server
> {noformat}
> h2. Building the collection
> We followed Exercise 2 from the quick start tutorial 
> ([http://lucene.apache.org/solr/guide/7_5/solr-tutorial.html#exercise-2]) - 
> for reference, I have attached a copy of the database.
> {noformat}
> mkdir -p /tmp/home
> echo '<?xml version="1.0" encoding="UTF-8" ?><solr></solr>' > 
> /tmp/home/solr.xml
> {noformat}
> In one terminal start a Solr instance in foreground:
> {noformat}
> ./bin/solr start -f -p 8983 -s /tmp/home
> {noformat}
> In another terminal, create a collection of movies, with no shards and no 
> replication:
> {noformat}
> bin/solr create -c films
> curl -X POST -H 'Content-type:application/json' --data-binary 
> '\\{"add-field": {"name":"name", "type":"text_general", "multiValued":false, 
> "stored":true}}' http://localhost:8983/solr/films/schema
> curl -X POST -H 'Content-type:application/json' --data-binary 
> '\{"add-copy-field" : {"source":"*","dest":"_text_"}}' 
> [http://localhost:8983/solr/films/schema]
> ./bin/post -c films example/films/films.json
> {noformat}
>            Reporter: Johannes Kloos
>            Assignee: Munendra S N
>            Priority: Minor
>              Labels: diffblue, newdev
>         Attachments: SOLR-13180.patch, SOLR-13180.patch, home.zip
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Requesting the following URL gives a 500 error due to a ClassCastException in 
> o.a.s.s.f.FacetModule: [http://localhost:8983/solr/films/select?json=0]
> The error response is caught by an uncaught ClassCastException, with the 
> stacktrace shown here:
> java.lang.ClassCastException: java.lang.Long cannot be cast to java.util.Map
> at org.apache.solr.search.facet.FacetModule.prepare(FacetModule.java:78)
> at 
> org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:272)
>  
> The cause of this bug is similar to #13178: line 78 in FacetModule reads
> {{jsonFacet = (Map<String, Object>) json.get("facet")}}
> and assumes that the JSON object contained in facet is a JSON object, while 
> we only guarantee that it is a JSON value.
> Line 92 semms to contain another situation like this, but I do not have a 
> test case handy for this specific case.
> This bug was found using [Diffblue Microservices 
> Testing|http://www.diffblue.com/labs]. Find more information on this [test 
> campaign|https://www.diffblue.com/blog/2018/12/19/diffblue-microservice-testing-a-sneak-peek-at-our-early-product-and-results].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to