atris commented on issue #923: LUCENE-8988: Introduce Global Feature Based Early Termination For Sorted Fields URL: https://github.com/apache/lucene-solr/pull/923#issuecomment-541869092 > That's the part that I don't really understand. For sorted indices, early termination will require to visit only a few documents per segment That is true *if* the segment is not composed of many competitive hits relative to the thread local PQ’s bottom. It is possible that a large segment might be deemed as competitive by the local bottom, but the global bottom thinks otherwise and leads to early termination of the segment. > we have a way to skip group of documents efficiently when sorted by relevancy but for other sort we can just bypass some checks in the priority queue. I am not sure if I understand how relaxing priority queue checks will allow global early termination? > I am not sure that we'll gain anything with a synchronized call on every hit. I could be convinced otherwise but we'll need some benchmark to verify that the change really brings something. That’s what benchmarks are for :) unfortunately luceneutil does not support sorted indices during querying — I know you had a local hack for the relevance skipping patch. Mind sharing details of the same, please? > I'd prefer that we find the best way to do this and then push to master. As it is there is no proof that the change brings anything and I'd like to commit #904 first so that you can build on top of it. I do not see how this PR blocks #904? The mentioned PR focuses on skipping documents when sorted by relevance and this PR focuses on early terminating segments which might be deemed competitive at the thread level but are not at a global level
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
