[ 
https://issues.apache.org/jira/browse/LUCENE-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967049#comment-16967049
 ] 

Mikhail Khludnev edited comment on LUCENE-9026 at 11/4/19 10:15 PM:
--------------------------------------------------------------------

{quote}I'm considering extending the query to implement Solr's 
[PostFilter|https://lucene.apache.org/solr/8_2_0/solr-core/org/apache/solr/search/PostFilter.html]
 interface. The ultimate goal of this is to make it more efficient to run this 
query with very large numbers of terms.
{quote}
Hello, [~gerlowskija]. 

Please notice 
[method=docValuesTermsFilter|https://lucene.apache.org/solr/guide/7_3/other-parsers.html#terms-query-parser],
 I suppose it does it underneath.  


was (Author: mkhludnev):
{quote}I'm considering extending the query to implement Solr's 
[PostFilter|https://lucene.apache.org/solr/8_2_0/solr-core/org/apache/solr/search/PostFilter.html]
 interface. The ultimate goal of this is to make it more efficient to run this 
query with very large numbers of terms.
{quote}
Hello, [~gerlowskija]. 

Please notice 
[method=docValuesTermsFilter|https://lucene.apache.org/solr/guide/7_3/other-parsers.html#terms-query-parser],
 I suppose it's done it underneath.  

> Make it easier to extend DocValuesTermsQuery
> --------------------------------------------
>
>                 Key: LUCENE-9026
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9026
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>    Affects Versions: master (9.0)
>            Reporter: Jason Gerlowski
>            Priority: Minor
>         Attachments: LUCENESOLR-9026.patch
>
>
> The visibility of some of the fields in DocValuesTermsQuery make it difficult 
> to efficiently subclass.  Especially the "termData" instance variable, which 
> is really core to the functioning of the class but is totally inaccessible 
> from any sub-classes, forcing subclasses to store a duplicate 
> PrefixCodedTerms object, and then juggle the state of both.
> Are there any objections to making "termData" (and potentiall some other 
> instance variables) protected instead of private for this class?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to