[ 
https://issues.apache.org/jira/browse/SOLR-13817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967788#comment-16967788
 ] 

Ben Manes commented on SOLR-13817:
----------------------------------

I was curiousing looking through 
[LruQueryCache|https://github.com/apache/lucene-solr/commits/master/lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java]
 which has a lot of JIRAs to deal with performance. There are a lot of tweaks 
to degrade cache efficiency to compensate for lock contention.

- It doesn't handle the cache stampedes
- It queries the entry to see if it's even worth caching, so that cheaper 
entries don't bang on the lock
- The cache lookup is skipped if the global lock is held and the value 
computed, but not stored, which means a busy lock reduces performance across 
all usages.

Would you be open to a new JIRA to investigate whether Caffeine would be a 
better internal implementation?

> Deprecate legacy SolrCache implementations
> ------------------------------------------
>
>                 Key: SOLR-13817
>                 URL: https://issues.apache.org/jira/browse/SOLR-13817
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Andrzej Bialecki
>            Assignee: Andrzej Bialecki
>            Priority: Major
>
> Now that SOLR-8241 has been committed I propose to deprecate other cache 
> implementations in 8x and remove them altogether from 9.0, in order to reduce 
> confusion and maintenance costs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to