[ https://issues.apache.org/jira/browse/SOLR-13794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051370#comment-17051370 ]
ASF subversion and git services commented on SOLR-13794: -------------------------------------------------------- Commit 76f74d1217666dc2391a4c4afc9f728e105c99dc in lucene-solr's branch refs/heads/branch_8x from Alan Woodward [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=76f74d1 ] SOLR-13794: Don't look for removed _default configset in addVersion.py > Delete solr/core/src/test-files/solr/configsets/_default > -------------------------------------------------------- > > Key: SOLR-13794 > URL: https://issues.apache.org/jira/browse/SOLR-13794 > Project: Solr > Issue Type: Test > Reporter: Chris M. Hostetter > Assignee: Chris M. Hostetter > Priority: Major > Fix For: master (9.0), 8.5 > > Attachments: SOLR-13794.patch, SOLR-13794.patch, > SOLR-13794_code_only.patch, SOLR-13794_code_only.patch > > > For as long as we've had a {{_default}} configset in solr, we've also had a > copy of that default in {{core/src/test-files/}} - as well as a unit test > that confirms they are identical. > It's never really been clear to me *why* we have this duplication, instead of > just having the test-framework take the necessary steps to ensure that > {{server/solr/configsets/_default}} is properly used when running tests. > I'd like to propose we eliminate the duplication since it only ever seems to > cause problems (notably spurious test failures when people modify the > {{_default}} configset w/o remembering that they need to make identical edits > to the {{test-files}} clone) and instead have {{SolrTestCase}} set the > (already existing & supported) {{solr.default.confdir}} system property to > point to the (already existing) {{ExternalPaths.DEFAULT_CONFIGSET}} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org