[
https://issues.apache.org/jira/browse/LUCENE-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051790#comment-17051790
]
ASF subversion and git services commented on LUCENE-9114:
---------------------------------------------------------
Commit d751cf626ec639d38b955d3962ae347aea00c0ac in lucene-solr's branch
refs/heads/master from Atri Sharma
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=d751cf6 ]
LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation (#1303)
This commit makes ValueSourceScorer's costing algorithm also take the delegated
FunctionValues's cost into consideration when calculating its cost.
FunctionValues now exposes a cost method which is used by ValueSourceScorer's
default matchCost method. In addition, ValueSourceScorer exposes a matchCost
method which can be overridden to specify a custom costing mechanism
> Add FunctionValues.cost
> -----------------------
>
> Key: LUCENE-9114
> URL: https://issues.apache.org/jira/browse/LUCENE-9114
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/query
> Reporter: David Smiley
> Assignee: Atri Sharma
> Priority: Major
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> The FunctionRangeQuery uses FunctionValues.getRangeScorer which returns a
> subclass of ValueSourceScorer. VSC's TwoPhaseIterator has a matchCost impl
> that returns a constant 100. This is pretty terrible; the cost should vary
> based on the complexity of the ValueSource provided to FRQ. ValueSource's
> are typically nested a number of levels, so they should aggregate.
> BTW there is a parallel concern for FunctionMatchQuery which works with
> DoubleValuesSource which doesn't have a cost either, and unsurprisingly there
> is a TPI with matchCost 100 there.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
