mbwaheed commented on a change in pull request #1317: SOLR-13101: Create metadataSuffix znode only at common shard creating api calls URL: https://github.com/apache/lucene-solr/pull/1317#discussion_r392545214
########## File path: solr/core/src/test/org/apache/solr/store/shared/metadata/SharedShardMetadataControllerTest.java ########## @@ -77,10 +77,26 @@ public void cleanup() throws Exception { */ @Test public void testSetupMetadataNode() throws Exception { - shardMetadataController.ensureMetadataNodeExists(TEST_COLLECTION_NAME, TEST_SHARD_NAME); + shardMetadataController.createMetadataNode(TEST_COLLECTION_NAME, TEST_SHARD_NAME); assertTrue(cluster.getZkClient().exists(metadataNodePath, false)); } + /** + * Test if we try to create the same metadat anode twice, we faile Review comment: few typos. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org