[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091408#comment-17091408
]
Stamatis Zampetakis commented on LUCENE-8811:
---------------------------------------------
So if I interpret well your response [~romseygeek], you are saying that
{{TermInSetQuery}} should accept an unlimited number of terms. Is that correct?
Looking again into the summary and discussion of this issue, I see that the
goal was to "make this check more consistent across queries". I don't clearly
see why {{TermInSetQuery}} should remain unbounded.
On the other hand, if we wanted to enforce the check only for a
{{BooleanQuery}} then why using the {{getNumClausesCheckVisitor}} visitor on
every query. I see that {{TermInSetQuery#visit}} for example already iterates
through all terms so if we don't need then we are just wasting CPU cycles
without a very good reason.
Sorry to insist on this but it is a change that will likely break our current
implementation in the downstream project and I guess it will also affect quite
a few others.
> Add maximum clause count check to IndexSearcher rather than BooleanQuery
> ------------------------------------------------------------------------
>
> Key: LUCENE-8811
> URL: https://issues.apache.org/jira/browse/LUCENE-8811
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Alan Woodward
> Priority: Minor
> Fix For: master (9.0)
>
> Attachments: LUCENE-8811.patch, LUCENE-8811.patch, LUCENE-8811.patch,
> LUCENE-8811.patch, LUCENE-8811.patch, LUCENE-8811.patch
>
>
> Currently we only check whether boolean queries have too many clauses.
> However there are other ways that queries may have too many clauses, for
> instance if you have boolean queries that have themselves inner boolean
> queries.
> Could we use the new Query visitor API to move this check from BooleanQuery
> to IndexSearcher in order to make this check more consistent across queries?
> See for instance LUCENE-8810 where a rewrite rule caused the maximum clause
> count to be hit even though the total number of leaf queries remained the
> same.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
