[ 
https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093929#comment-17093929
 ] 

Mikhail Khludnev commented on LUCENE-9328:
------------------------------------------

[~romseygeek], you are welcome 
[https://github.com/apache/lucene-solr/pull/1462/]

At the patch all type docvalues pooled already. I'm not sure I understand what 
you mean in _control advancing the iterators_. Now there's no control. It's not 
so scary as it looked at the first glance. Collector scores docs in-order 
(o'rlly?), every doc just kicks a certain GroupHead, which pull a value(s) from 
it. And that's it. I don't even think they ever call dv.advanceExact() for the 
current dv.docID. I think I'll add a test covering grouping/sorting over 
sortedset dvs. 

> SortingGroupHead to reuse DocValues
> -----------------------------------
>
>                 Key: LUCENE-9328
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9328
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/grouping
>            Reporter: Mikhail Khludnev
>            Assignee: Mikhail Khludnev
>            Priority: Minor
>         Attachments: LUCENE-9328.patch, LUCENE-9328.patch, LUCENE-9328.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> That's why 
> https://issues.apache.org/jira/browse/LUCENE-7701?focusedCommentId=17084365&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17084365



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to