[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096654#comment-17096654 ]
Mike Drob commented on LUCENE-7788: ----------------------------------- [~erickerickson] - I think you broke some logging at https://github.com/apache/lucene-solr/blob/26c9fce5db22299d90f9359e8ede324a44dc5e8e/solr/core/src/java/org/apache/solr/core/CoreContainer.java#L899 - missing concatenation so the message looks like: {{CoreContainer Not all security plugins configured! authentication=you make it}} Not sure if this same pattern applies elsewhere. I don't know if we have static analysis to catch a format string with some number of \{\} and then making sure that we have the right number of arguments. > fail precommit on unparameterised log messages and examine for wasted > work/objects > ---------------------------------------------------------------------------------- > > Key: LUCENE-7788 > URL: https://issues.apache.org/jira/browse/LUCENE-7788 > Project: Lucene - Core > Issue Type: Task > Reporter: Christine Poerschke > Assignee: Erick Erickson > Priority: Minor > Attachments: LUCENE-7788.patch, LUCENE-7788.patch, gradle_only.patch, > gradle_only.patch > > Time Spent: 50m > Remaining Estimate: 0h > > SOLR-10415 would be removing existing unparameterised log.trace messages use > and once that is in place then this ticket's one-line change would be for > 'ant precommit' to reject any future unparameterised log.trace message use. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org