madrob commented on a change in pull request #1371:
URL: https://github.com/apache/lucene-solr/pull/1371#discussion_r418718546
##########
File path:
solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java
##########
@@ -128,6 +128,28 @@ field collapsing (with ngroups) when the number of
distinct groups
public static final String HINT_TOP_FC = "top_fc";
public static final String HINT_MULTI_DOCVALUES = "multi_docvalues";
+ public enum NullPolicy {
+ IGNORE("ignore", 0),
Review comment:
Can we get rid of the earlier String declarations too? Lines 125-127?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
