[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107668#comment-17107668 ]
Mikhail Khludnev commented on LUCENE-9328: ------------------------------------------ Finally, after sneaking [~romseygeek] hack for {{leafContext}} my patch passed {{TestGroupingSearch}}. I'm too jealous to choose between two approaches. I feel like my approach is fragile to ValueSource and Comparators invoking {{dv.advance()}}. [^LUCENE-9328.patch] enforces the to use {{advanceExact()}}. Following this idea might lead to extreme or revoking {{advance()}} from DocValues in favor of {{advanceExact()}}. Can we have more opinions/votes/ideas here? > SortingGroupHead to reuse DocValues > ----------------------------------- > > Key: LUCENE-9328 > URL: https://issues.apache.org/jira/browse/LUCENE-9328 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/grouping > Reporter: Mikhail Khludnev > Assignee: Mikhail Khludnev > Priority: Minor > Attachments: LUCENE-9328.patch, LUCENE-9328.patch, LUCENE-9328.patch, > LUCENE-9328.patch, LUCENE-9328.patch, LUCENE-9328.patch, LUCENE-9328.patch, > LUCENE-9328.patch, LUCENE-9328.patch, LUCENE-9328.patch, LUCENE-9328.patch, > LUCENE-9328.patch > > Time Spent: 1h 50m > Remaining Estimate: 0h > > That's why > https://issues.apache.org/jira/browse/LUCENE-7701?focusedCommentId=17084365&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17084365 -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org