[
https://issues.apache.org/jira/browse/LUCENE-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108694#comment-17108694
]
Erick Erickson commented on LUCENE-9323:
----------------------------------------
Fat-fingered the commit message and recorded 9232 instead. The SHAs are:
Commit 88aff5d0061534bf709246ccfc963d64f9825767 in lucene-solr's branch
refs/heads/master from erick
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=88aff5d ]
LUCENE-9232: Fix or suppress 13 resource leak precommit warnings in
lucene/replicator
[
https://issues.apache.org/jira/browse/LUCENE-9232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108689#comment-17108689
]
ASF subversion and git services commented on LUCENE-9232:
---------------------------------------------------------
Commit b7b6e4a072f3fe665dc37b0d9c6f993d1be10d11 in lucene-solr's branch
refs/heads/branch_8x from erick
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b7b6e4a ]
LUCENE-9232: Fix or suppress 13 resource leak precommit warnings in
lucene/replicator
> Fix or suppress 13 resource leak precommit warnings in lucene/replicator
> ------------------------------------------------------------------------
>
> Key: LUCENE-9323
> URL: https://issues.apache.org/jira/browse/LUCENE-9323
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Andras Salamon
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 8.6
>
> Attachments: LUCENE-9323-01.patch, LUCENE-9323-01.patch
>
>
> There are 13 resource leak precommit warnings in org/apache/lucene/replicator:
> {noformat}
> [ecj-lint] 1. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/ReplicatorTestCase.java
> (at line 102) [ecj-lint] 1. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/ReplicatorTestCase.java
> (at line 102) [ecj-lint] ServerConnector c = new ServerConnector(server,
> new SslConnectionFactory(sslcontext, "http/1.1"), [ecj-lint]
> ^ [ecj-lint] Resource leak: 'c' is never closed-- [ecj-lint] 2. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/ReplicatorTestCase.java
> (at line 106) [ecj-lint] ServerConnector c = new ServerConnector(server,
> new HttpConnectionFactory()); [ecj-lint] ^ [ecj-lint]
> Resource leak: 'c' is never closed-- [ecj-lint] 3. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
> (at line 221) [ecj-lint] LineFileDocs docs = new LineFileDocs(random());
> [ecj-lint] ^^^^ [ecj-lint] Resource leak: 'docs' is never
> closed-- [ecj-lint] 4. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
> (at line 291) [ecj-lint] LineFileDocs docs = new LineFileDocs(random());
> [ecj-lint] ^^^^ [ecj-lint] Resource leak: 'docs' is never
> closed-- [ecj-lint] 5. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
> (at line 341) [ecj-lint] LineFileDocs docs = new LineFileDocs(random());
> [ecj-lint] ^^^^ [ecj-lint] Resource leak: 'docs' is never
> closed-- [ecj-lint] 6. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
> (at line 387) [ecj-lint] LineFileDocs docs = new LineFileDocs(random());
> [ecj-lint] ^^^^ [ecj-lint] Resource leak: 'docs' is never
> closed-- [ecj-lint] 7. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
> (at line 430) [ecj-lint] LineFileDocs docs = new LineFileDocs(random());
> [ecj-lint] ^^^^ [ecj-lint] Resource leak: 'docs' is never
> closed-- [ecj-lint] 8. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
> (at line 495) [ecj-lint] LineFileDocs docs = new LineFileDocs(random());
> [ecj-lint] ^^^^ [ecj-lint] Resource leak: 'docs' is never
> closed-- [ecj-lint] 9. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
> (at line 539) [ecj-lint] LineFileDocs docs = new LineFileDocs(random());
> [ecj-lint] ^^^^ [ecj-lint] Resource leak: 'docs' is never
> closed-- [ecj-lint] 10. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
> (at line 665) [ecj-lint] LineFileDocs docs = new LineFileDocs(random());
> [ecj-lint] ^^^^ [ecj-lint] Resource leak: 'docs' is never
> closed-- [ecj-lint] 11. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
> (at line 720) [ecj-lint] LineFileDocs docs = new LineFileDocs(random());
> [ecj-lint] ^^^^ [ecj-lint] Resource leak: 'docs' is never
> closed-- [ecj-lint] 12. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
> (at line 785) [ecj-lint] LineFileDocs docs = new LineFileDocs(random());
> [ecj-lint] ^^^^ [ecj-lint] Resource leak: 'docs' is never
> closed-- [ecj-lint] 13. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestStressNRTReplication.java
> (at line 1062) [ecj-lint] LineFileDocs docs = new LineFileDocs(random());
> [ecj-lint] ^^^^ [ecj-lint] Resource leak: 'docs' is never
> closed {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
