gerlowskija opened a new pull request #1574: URL: https://github.com/apache/lucene-solr/pull/1574
# Description When reading through logs, associating the log message from the coordinator node with the messages for per-shard requests downstream can be difficult. Nothing unique (or semi-uniquely) identifies shard requests as being part of an upstream request. # Solution This PR makes use of the NOW param that is already added to all downstream shard requests, and adds it to the log message from the coordinator node as well. While NOW isn't strictly unique (it's a millisecond-granularity timestamp), the combination of NOW and the request params should allow debugging administrators to trace per-shard requests to a coordinator request (and vice versa) with confidence. # Tests Manual testing to ensure the log field is added in appropriate situations. No added automated tests, though if anyone knows a dependable way to do so, I'm open to it. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [x] I have run `ant precommit` and the appropriate test suite. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
