megancarey commented on a change in pull request #1592:
URL: https://github.com/apache/lucene-solr/pull/1592#discussion_r444544150
##########
File path:
solr/core/src/java/org/apache/solr/cloud/autoscaling/AutoScalingHandler.java
##########
@@ -542,7 +542,7 @@ private AutoScalingConfig handleSetTrigger(SolrQueryRequest
req, SolrQueryRespon
String eventTypeStr = op.getStr(EVENT);
if (op.hasError()) return currentConfig;
- TriggerEventType eventType =
TriggerEventType.valueOf(eventTypeStr.trim().toUpperCase(Locale.ROOT));
+ TriggerEventType.valueOf(eventTypeStr.trim().toUpperCase(Locale.ROOT));
Review comment:
If the eventTypeStr is an invalid event type, it will throw an exception
that there are no matches in TriggerEventType enum. I'll add a comment so the
reason for this line is more obvious.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
