markharwood commented on a change in pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r445497621
##########
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##########
@@ -439,12 +441,19 @@
/**
* Syntax flag, enables all optional regexp syntax.
*/
- public static final int ALL = 0xffff;
-
+ public static final int ALL = 0xff;
+
/**
* Syntax flag, enables no optional regexp syntax.
*/
public static final int NONE = 0x0000;
+
+ //----- Matching flags ( > 0xff ) ------
+
+ /**
+ * Allows case insensitive matching of ASCII characters.
+ */
+ public static final int ASCII_CASE_INSENSITIVE = 0x0100;
Review comment:
UNICODE_CASE_INSENSITIVE or just CASE_INSENSITIVE?
Either way it would cover ASCII and all other UNICODE characters.
Admittedly slightly odd that the two flags overlap but the alternative is
people may assume that a non-qualified name like "CASE_INSENSITIVE" would cover
all the bases when we only currently support ASCII.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
