dsmiley commented on a change in pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r448563603
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##########
@@ -510,14 +510,18 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
}
private void tagRequestWithRequestId(ResponseBuilder rb) {
- String rid = getRequestId(rb.req);
- if (StringUtils.isBlank(rb.req.getParams().get(CommonParams.REQUEST_ID))) {
- ModifiableSolrParams params = new
ModifiableSolrParams(rb.req.getParams());
- params.add(CommonParams.REQUEST_ID, rid);//add rid to the request so
that shards see it
- rb.req.setParams(params);
- }
- if (rb.isDistrib) {
- rb.rsp.addToLog(CommonParams.REQUEST_ID, rid); //to see it in the logs
of the landing core
+ final String disableFlag =
rb.req.getParams().get(CommonParams.DISABLE_REQUEST_ID);
Review comment:
I don't think this flag should be a request parameter; I think it should
be a "Cluster Property".
Secondly, if you do need to get this from a SolrParams, see `getBool`
method, accepting a default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
