dsmiley commented on a change in pull request #1669:
URL: https://github.com/apache/lucene-solr/pull/1669#discussion_r455511455
##########
File path: solr/core/src/java/org/apache/solr/core/ConfigSet.java
##########
@@ -79,4 +75,14 @@ public NamedList getProperties() {
public boolean isTrusted() {
return trusted;
}
+
+ /**Provide a Schema object on demand
Review comment:
https://google.github.io/styleguide/javaguide.html#s7-javadoc
Glad to see this supplier though.
##########
File path:
solr/core/src/java/org/apache/solr/pkg/PackageListeningClassLoader.java
##########
@@ -35,7 +35,7 @@
* This class would register a listener each package that is loaded through
this
* if any of those packages are updated , the onReload runnable is executed
* */
-public class MultiPackageListener implements SolrClassLoader ,
PackageListeners.Listener {
+public class PackageListeningClassLoader implements SolrClassLoader ,
PackageListeners.Listener {
Review comment:
Good name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
