[ 
https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159465#comment-17159465
 ] 

Ishan Chattopadhyaya commented on SOLR-14613:
---------------------------------------------

I just took a brief look at the PR #1678.

Here is where I thought we were going.
# Our current "autoscaling framework" is tightly coupled with many parts of 
Solr. Plan was to decouple it completely and leave behind a minimal footprint 
with the new autoscaling framework.
# There will be only minimal set of interfaces that will be plugged into by 
external packages, i.e. code not living in the Solr core codebase.

However, I am confused looking at this PR.
# This does nothing to make the current situation better.
# It piles on more code into core.
# There is no description/documentation/definition of the interfaces introduced 
here.

I think as a first step, we should deprecate current autoscaling framework (as 
it is something that doesn't work efficiently anyway). In master, we should 
remove *all traces* of autoscaling code right away and start absolutely afresh.

> Provide a clean API for pluggable autoscaling implementations
> -------------------------------------------------------------
>
>                 Key: SOLR-14613
>                 URL: https://issues.apache.org/jira/browse/SOLR-14613
>             Project: Solr
>          Issue Type: Improvement
>          Components: AutoScaling
>            Reporter: Andrzej Bialecki
>            Priority: Major
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> As described in SIP-8 the current autoscaling Policy implementation has 
> several limitations that make it difficult to use for very large clusters and 
> very large collections. SIP-8 also mentions the possible migration path by 
> providing alternative implementations of the placement strategies that are 
> less complex but more efficient in these very large environments.
> We should review the existing APIs that the current autoscaling engine uses 
> ({{SolrCloudManager}} , {{AssignStrategy}} , {{Suggester}} and related 
> interfaces) to see if they provide a sufficient and minimal API for plugging 
> in alternative autoscaling placement strategies, and if necessary refactor 
> the existing APIs.
> Since these APIs are internal it should be possible to do this without 
> breaking back-compat.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to