gerlowskija opened a new pull request #1707: URL: https://github.com/apache/lucene-solr/pull/1707
# Description Solr offers several different join implementations which can be switched off providing the "method" local-param on JoinQuery's. Each of these implementations has different performance characteristics and can behave very differently depending on a user's data and use case. When joins are used internally as a part of JSON Faceting's "join" domain-transform though, users have no way to specify which implementation they would like to use. We should correct this by adding a "method" property to the join domain-transform. This will let user's choose the join that's most performant for their use case during JSON Facet requests. # Solution Adds parsing to FacetRequest for a 'method' value, which is then forwarded to JoinQParserPlugin.createJoinQuery to create the appropriate join-type. # Tests None, yet. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [X] I have developed this patch against the `master` branch. - [ ] I have run `ant precommit` and the appropriate test suite. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
