[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172213#comment-17172213 ]
Michael McCandless commented on LUCENE-9444: -------------------------------------------- {quote}Should this class extends {{DocIdSetIterator}} to allow intersection with another {{DocIdSetIterator}} created from {{FacetsCollector.MatchingDoc.bits}} ? {quote} I think so? {quote}Making {{dim}} part of ctor feels a bit restrictive, how about providing 2 separate APIs, one that accepts dimension and another that does not ? {quote} Maybe the method that produces the iterator could optionally take a {{dim}} to filter for only those labels under that dimension? {quote}how about returning a {{java.util.Iterator<FacetLabel>}} instead of {{FacetLabel[]}} ? {quote} +1 > Need an API to easily fetch facet labels for a field in a document > ------------------------------------------------------------------ > > Key: LUCENE-9444 > URL: https://issues.apache.org/jira/browse/LUCENE-9444 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/facet > Affects Versions: 8.6 > Reporter: Ankur > Priority: Major > > A facet field may be included in the list of fields whose values are to be > returned for each hit. > In order to get the facet labels for each hit we need to > # Create an instance of _DocValuesOrdinalsReader_ and invoke > _getReader(LeafReaderContext context)_ method to obtain an instance of > _OrdinalsSegmentReader()_ > # _OrdinalsSegmentReader.get(int docID, IntsRef ordinals)_ method is then > used to fetch and decode the binary payload in the document's BinaryDocValues > field. This provides the ordinals that refer to facet labels in the > taxonomy.** > # Lastly TaxonomyReader.getPath(ord) is used to fetch the labels to be > returned. > > Ideally there should be a simple API - *String[] getLabels(docId)* that hides > all the above details and gives us the string labels. This can be part of > *TaxonomyFacets* but that's just one idea. > I am opening this issue to get community feedback and suggestions. > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org