rishisankar opened a new pull request #1770: URL: https://github.com/apache/lucene-solr/pull/1770
<!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr: * https://issues.apache.org/jira/projects/LUCENE * https://issues.apache.org/jira/projects/SOLR You will need to create an account in Jira in order to create an issue. The title of the PR should reference the Jira issue number in the form: * LUCENE-####: <short description of problem or changes> * SOLR-####: <short description of problem or changes> LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description This change adds a standard `CompletableFuture<NamedList<Object>> requestAsync(SolrRequest<?> request)` API to SolrClient, implemented for Http2SolrClient and CloudHttp2SolrClient (Http2SolrClient already had an async method implemented recently, but this was not standard/not extended to the cloud client). Additionally, this change removes custom AsyncListener/Cancellable interfaces, instead using CompletableFuture as a standard for async request methods. # Solution * An async method was already added to Http2SolrClient in [SOLR-14354](https://github.com/apache/lucene-solr/pull/1470/files). This change refactors the already existing method to fit the new method signature * The LBHttp2SolrClient has a separate async method using its internal Req/Rsp classes, also added in SOLR-14354. This change also refactors this method to use CompletableFuture (although this doesn't override the SolrClient API, as it still uses Req/Rsp). * Http2SolrCloudClient uses an LBHttp2SolrClient internally, so it can utilize LBHttp2SolrClient's async request method to make async calls as well. This refactors BaseCloudSolrClient to add CompletableFuture support so that Http2SolrClient can make async requests. * For now, SolrClient will throw an UnsupportedOperationException if requestAsync method is called on a client besides Http2SolrClient or CloudHttp2SolrClient. # Tests Test cases are still in progress (hence draft PR), but so far I've added test cases to Http2SolrClient to test async requests in the same way synchronous requests are tested. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [x] I have run `ant precommit` and the appropriate test suite. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
