der-eismann opened a new pull request #1771:
URL: https://github.com/apache/lucene-solr/pull/1771


   # Description
   
   Solr checks the zookeeper status in the admin UI and explicitly expects 
integers to be delivered. However if you enable the prometheus plugin in 
zookeeper, all values are posted as floats instead which breaks the existing 
check.
   
   # Solution
   
   This is a small fix to parse the values as floats and cast them into an 
integer. This should be fine since the number of followers can't actually be a 
float and the part behind the dot is always 0.
   
   # Tests
   
   None. This is my first Java contribution ever, so I'm happy for any clue how 
to do this.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [ ] I have run `ant precommit` and the appropriate test suite.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref 
Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) 
(for Solr changes only).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to