[
https://issues.apache.org/jira/browse/SOLR-14765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182074#comment-17182074
]
Mike Drob commented on SOLR-14765:
----------------------------------
The explanation of the no commit makes a lot of sense, and clarifies a few
things. That was one of the big questions I had - why do we need to add those
sorts in the test, but the lack of test independence totally answers that.
I think that all of our unit tests should be independent, so maybe that means
that we have to refactor EDRT to use new collections between each test? Or drop
caches (would a soft commit do this?)
Does cursorMark with rows=0 make sense? nextCursorMark will always be equal to
the current cursor, no? So there's no reason to sort at all.
> optimize DocList creation by skipping sort for sort-irrelevant cases
> --------------------------------------------------------------------
>
> Key: SOLR-14765
> URL: https://issues.apache.org/jira/browse/SOLR-14765
> Project: Solr
> Issue Type: Improvement
> Affects Versions: master (9.0)
> Reporter: Michael Gibney
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When {{rows=0}}, and for {{MatchAllDocsQuery}} and {{ConstantScoreQuery}}
> (and possibly others?), it is possible for
> {{SolrIndexSearcher.getDocListC(QueryResult, QueryCommand)}} to create a
> DocList directly from {{filterCache}} DocSets -- similar to
> {{useFilterForSortedQuery}}, but without actually sorting.
> This results in significant benefits for high-recall domains, including the
> common (and commonly-cached) use-case of {{q=\*:*}} and {{fq}}, facets, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
