[ https://issues.apache.org/jira/browse/LUCENE-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190628#comment-17190628 ]
Dawid Weiss commented on LUCENE-9497: ------------------------------------- The compilation problem was caused by the fact that we exclude error prone from published/ runtime dependencies (transitive dependency from guava) but at the same time if it's missing, error prone's annotation processor can complain about missing annotation types. Not to mention each and every of these dependencies uses a different version of error_prone_annotations... this is confusing like hell, sigh. I think I fixed most of these issues here: https://github.com/apache/lucene-solr/pull/1828 I also looked at how individual pieces of code can be marked as valid - error prone uses regular SuppressWarnings annotation with custom names for each category. This is fine, I think. > Integerate Error Prone ( Static Analysis Tool ) during compilation > ------------------------------------------------------------------ > > Key: LUCENE-9497 > URL: https://issues.apache.org/jira/browse/LUCENE-9497 > Project: Lucene - Core > Issue Type: Task > Reporter: Varun Thacker > Priority: Minor > Time Spent: 3.5h > Remaining Estimate: 0h > > Integrate [https://github.com/google/error-prone] during compilation of our > source code to catch mistakes -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org