[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193350#comment-17193350
]
Ankur edited comment on LUCENE-9444 at 9/10/20, 5:06 PM:
---------------------------------------------------------
Thanks [~mikemccand]. I uploaded a new patch that incorporates the code review
feed. The patch
* Makes {{FacetLabelReader}} public as suggested.
* Adds javadoc explaining why {{FacetLabelReader}} is not thread-safe.
* Eliminates {{Iterator}} and replaces {{lookupLabels()}} methods with
{{nextFacetLabel()}} methods that just return {{null}} if no more FacetLabels
exist for input docId.
* Adds {{@lucene.experimental}} to class level javadocs.
* Enhances {{TestTaxonomyLabels.testBasic()}} method to check that fetching
FacetLabels in decreasing docId order throws {{AssertionError.}}
was (Author: goankur):
Thanks [~mikemccand]. I uploaded a new patch that incorporates the code review
feed. The patch
* Makes {{FacetLabelReader}} public as suggested.
* Adds javadoc to explaining that {{FacetLabelReader}} is not thread-safe.
* Eliminates {{Iterator}} and replaces {{lookupLabels()}} methods with
{{nextFacetLabel()}} methods that just return {{null}} if no more FacetLabels
exist for input docId.
* Adds {{@lucene.experimental}} to class level javadocs.
* Enhances {{TestTaxonomyLabels.testBasic()}} method to check that fetching
FacetLabels in decreasing docId order throws {{AssertionError.}}
> Need an API to easily fetch facet labels for a field in a document
> ------------------------------------------------------------------
>
> Key: LUCENE-9444
> URL: https://issues.apache.org/jira/browse/LUCENE-9444
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Affects Versions: 8.6
> Reporter: Ankur
> Priority: Major
> Labels: facet
> Attachments: LUCENE-9444.patch, LUCENE-9444.v2.patch
>
>
> A facet field may be included in the list of fields whose values are to be
> returned for each hit.
> In order to get the facet labels for each hit we need to
> # Create an instance of _DocValuesOrdinalsReader_ and invoke
> _getReader(LeafReaderContext context)_ method to obtain an instance of
> _OrdinalsSegmentReader()_
> # _OrdinalsSegmentReader.get(int docID, IntsRef ordinals)_ method is then
> used to fetch and decode the binary payload in the document's BinaryDocValues
> field. This provides the ordinals that refer to facet labels in the
> taxonomy.**
> # Lastly TaxonomyReader.getPath(ord) is used to fetch the labels to be
> returned.
>
> Ideally there should be a simple API - *String[] getLabels(docId)* that hides
> all the above details and gives us the string labels. This can be part of
> *TaxonomyFacets* but that's just one idea.
> I am opening this issue to get community feedback and suggestions.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
