[
https://issues.apache.org/jira/browse/SOLR-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206151#comment-17206151
]
Erick Erickson commented on SOLR-14910:
---------------------------------------
[~dsmiley] pointed out that having to muck with the gradle build system to
handle non-standard logger declarations is yucky, and looking back at that code
I don't know what I was thinking. We already have a //logok flag, and adding
being able to ignore a declaration if that tag is present isn't nearly so yucky.
For instance, HttpServer2.java requires an upper-case LOG in order for Hadoop
to function (yuck) and we want our log variables to be just lower-case "log".
Or SolrCore.java declares requestLog and slowLog, which are perfectly valid but
aren't just "log".
Along the way, David suggested that //nowarn is more general and can be used in
other situations than a specific //logok, which makes sense.
PR shortly. I'll commit this probably tomorrow absent objections.
> Use in-line tags for logger declarations in Gradle ValidateLogCalls that are
> non-standard
> -----------------------------------------------------------------------------------------
>
> Key: SOLR-14910
> URL: https://issues.apache.org/jira/browse/SOLR-14910
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
